allow passing callbacks to registerAdmin/registerPersonal#5173
Closed
icewind1991 wants to merge 1 commit intomasterfrom
Closed
allow passing callbacks to registerAdmin/registerPersonal#5173icewind1991 wants to merge 1 commit intomasterfrom
icewind1991 wants to merge 1 commit intomasterfrom
Conversation
This can be used by an app to prevent having to determine what settings pages needs to be added if the result is never used Signed-off-by: Robin Appelman <robin@icewind.nl>
|
@icewind1991, thanks for your PR! By analyzing the history of the files in this pull request, we identified @Xenopathic, @MorrisJobke and @georgehrke to be potential reviewers. |
Member
Author
|
https://github.com/nextcloud/server/pull/5173/files?w=1 for reviewing the changes without phpstorm deciding that it really wants to reformat the code |
Member
|
Can we defer it until #4890 is done? Probably it won't be necessary then at all. |
Codecov Report
@@ Coverage Diff @@
## master #5173 +/- ##
============================================
- Coverage 54.14% 54.14% -0.01%
- Complexity 22286 22295 +9
============================================
Files 1379 1379
Lines 85335 85336 +1
Branches 1321 1321
============================================
- Hits 46208 46207 -1
- Misses 39127 39129 +2
|
Merged
Member
Author
|
superseded by #4890 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This can be used by an app to prevent having to determine what settings pages needs to be added if the result is never used
Adjusted the files_external settings page to use the new callback option, this saved 4 db queries for each request made