fix(IFilenameValidator): correctly handle case insensitivity#51611
Merged
fix(IFilenameValidator): correctly handle case insensitivity#51611
Conversation
susnux
added
bug
3. to review
susnux
requested review from
Altahrim,
icewind1991 and
sorbaugh
and removed request for
a team
Contributor
Author
|
/backport to stable31 |
Contributor
Author
|
/backport to stable30 |
- forbidden names and forbidden base names are case **insensitive** so we need to check all lowercase here. - add test that config value is also read case insensitive. Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
susnux
force-pushed
the
fix/file-name-validator-case-sensitivity
branch
from
bde1194 to
254dd85
Compare
AndyScherzinger
approved these changes
Mar 22, 2025
come-nc
approved these changes
Mar 24, 2025
This was referenced Mar 24, 2025
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Checklist