Skip to content

fix(mimetypes): drop tar.gz and tar.bz2 and adjust tgz#51405

Merged
skjnldsv merged 1 commit intomasterfrom
fix/mime
Mar 12, 2025
Merged

fix(mimetypes): drop tar.gz and tar.bz2 and adjust tgz#51405
skjnldsv merged 1 commit intomasterfrom
fix/mime

Conversation

@susnux
Copy link
Contributor

@susnux susnux commented Mar 11, 2025

Summary

  1. mimetypes with a dot do not work with our mime detector (only checks last dot).
  2. all of those files are tar files compressed as gzip / bzip2 so the real mimetype of the file is the compression not the tar.

We could at max. set mime to application/x-tar+gzip.

Checklist

@susnux
fix(mimetypes): drop tar.gz and tar.bz2 and adjust tgz
a234ef1 
1. mimetypes with a dot do not work with our mime detector (only checks
   last dot).
2. all of those files are tar files compressed as gzip / bzip2 so the
   real mimetype of the file is the compression not the tar.

We could at max. set mime to `application/x-tar+gzip`.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux susnux added bug 3. to review Waiting for reviews labels Mar 11, 2025
@susnux susnux requested a review from a team as a code owner March 11, 2025 20:38
@susnux susnux requested review from Altahrim, icewind1991 and skjnldsv and removed request for a team March 11, 2025 20:38
@skjnldsv skjnldsv merged commit bada83a into master Mar 12, 2025
121 checks passed
@skjnldsv skjnldsv deleted the fix/mime branch March 12, 2025 07:48
@skjnldsv
Copy link
Member

skjnldsv commented Mar 12, 2025

/backport to stable31

@skjnldsv
Copy link
Member

skjnldsv commented Mar 12, 2025

/backport to stable30

This was referenced Mar 12, 2025
Merged
Merged
@skjnldsv
Copy link
Member

skjnldsv commented Mar 12, 2025

/backport to stable29

@backportbot backportbot bot mentioned this pull request Mar 12, 2025
Merged
@skjnldsv
Copy link
Member

skjnldsv commented Mar 12, 2025 •
edited
Loading

EDIT: was a test

@backportbot

This comment was marked as resolved.

Sign in to view
@kesselb kesselb mentioned this pull request Mar 12, 2025
Closed
@nextcloud-bot nextcloud-bot mentioned this pull request Aug 19, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kesselb kesselb kesselb approved these changes

@skjnldsv skjnldsv skjnldsv approved these changes

@icewind1991 icewind1991 Awaiting requested review from icewind1991 icewind1991 is a code owner automatically assigned from nextcloud/server-backend

@Altahrim Altahrim Awaiting requested review from Altahrim Altahrim is a code owner automatically assigned from nextcloud/server-backend

Assignees

No one assigned

Labels

3. to review Waiting for reviews bug

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Bug]: Conflicting mimetype for gz/tar.gz files in mimetypemapping.dist.json

3 participants

@susnux @skjnldsv @kesselb