fix(files): Don't do session related work in the constructor of the View#51259
Merged
provokateurin merged 2 commits intomasterfrom Mar 5, 2025
Merged
Conversation
nickvergessen
requested review from
ArtificialOwl,
nfebe and
provokateurin
and removed request for
a team
Signed-off-by: Joas Schilling <coding@schilljs.com>
nickvergessen
force-pushed
the
bugfix/50619/no-session-work-in-constructor
branch
from
d7f7b70 to
0522b03
Compare
susnux
approved these changes
Mar 5, 2025
Signed-off-by: Marcel Müller <marcel-mueller@gmx.de>
AndyScherzinger
approved these changes
Mar 5, 2025
8 tasks
Contributor
|
We got confirmation from 3 users, that the patch works! |
Member
|
Backports needed? |
Contributor
|
/backport to stable31 |
Contributor
|
/backport to stable30 |
This was referenced Mar 5, 2025
Contributor
|
/backport to stable29 |
Member
|
/backport to stable28 |
2 tasks
6 tasks
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist