fix: remote account activity translation#51216
Merged
SebastianKrupinski merged 1 commit intomasterfrom Mar 7, 2025
Merged
Conversation
SebastianKrupinski
changed the title
| if (!isset($parsedParameters['user'])) { | ||
| // External user via public link share | ||
| $subject = str_replace('{user}', $this->activityLang->t('"remote account"'), $subject); | ||
| $subject = str_replace('{user}', $this->l->t('"remote account"'), $subject); |
Member
There was a problem hiding this comment.
@nickvergessen could you please check if this is fine? activityLang was introduced in #4969
Member
There was a problem hiding this comment.
Should be fine, I guess (2016) we tried to avoid translating it twice.
ChristophWurst
approved these changes
Mar 4, 2025
Member
ChristophWurst
left a comment
ChristophWurst
left a comment
There was a problem hiding this comment.
Looks good but didn't test
Contributor
Author
|
/backport to stable31 |
Contributor
Author
|
/backport to stable30 |
Contributor
Author
|
/backport to stable29 |
ChristophWurst
added
4. to release
Signed-off-by: SebastianKrupinski <krupinskis05@gmail.com>
SebastianKrupinski
force-pushed
the
fix/noid/remote-account-activity-translation
branch
from
c6272de to
45a49e8
Compare
SebastianKrupinski
requested review from
ArtificialOwl,
artonge and
sorbaugh
and removed request for
a team
SebastianKrupinski
deleted the
fix/noid/remote-account-activity-translation
branch
This was referenced Mar 7, 2025
4 tasks
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Checklist