feat(occ): add json output option to admin-delegation:show#51124
feat(occ): add json output option to admin-delegation:show#51124leftybournes wants to merge 3 commits intonextcloud:masterfrom
Conversation
73bf32a to
cfb7568
Compare
artonge
left a comment
There was a problem hiding this comment.
Looks good, only one comment about code duplication
Signed-off-by: Kent Delante <[email protected]>
Signed-off-by: Kent Delante <[email protected]>
Signed-off-by: Kent Delante <[email protected]>
cfb7568 to
1be410c
Compare
artonge
left a comment
There was a problem hiding this comment.
I would have let the getDelegatedSettings block at the bottom to reduce the diff, but looks good anyway.
Thanks for the tip. I'll keep that in mind next time. |
|
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! (If you believe you should not receive this message, you can add yourself to the blocklist.) |
|
Closing this in favor of #55260 |
Summary
Add option to output json with admin-delegation:show using --output=json or --output=json_pretty
Example Output (plain json):
Example Output (pretty json):
Checklist