Merged
Conversation
Signed-off-by: Louis Chemineau <louis@chmn.me>
artonge
added
bug
3. to review
come-nc
reviewed
Feb 27, 2025
lib/private/Authentication/Login/FlowV2EphemeralSessionsCommand.php
Outdated
Show resolved
Hide resolved
artonge
force-pushed
the
artonge/fix/epehmeral_sessions
branch
from
fee33ea to
c613a52
Compare
susnux
reviewed
Feb 27, 2025
lib/private/Authentication/Login/FlowV2EphemeralSessionsCommand.php
Outdated
Show resolved
Hide resolved
Signed-off-by: Louis Chemineau <louis@chmn.me>
artonge
force-pushed
the
artonge/fix/epehmeral_sessions
branch
from
c613a52 to
68f86b3
Compare
susnux
approved these changes
Feb 27, 2025
Contributor
susnux
left a comment
susnux
left a comment
There was a problem hiding this comment.
Makes sense from my side, but did not test it.
come-nc
approved these changes
Feb 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up of #51051