fix(files_sharing): Fix stray groups not being cleaned up from shares when deleted#51012
fix(files_sharing): Fix stray groups not being cleaned up from shares when deleted#51012
Conversation
… when deleted Signed-off-by: Christopher Ng <chrng8@gmail.com>
Signed-off-by: Christopher Ng <chrng8@gmail.com>
Signed-off-by: Christopher Ng <chrng8@gmail.com>
Signed-off-by: Christopher Ng <chrng8@gmail.com>
Pytal
added
bug
3. to review
Pytal
requested review from
skjnldsv and
sorbaugh
and removed request for
a team
|
/backport to stable31 |
|
/backport to stable30 |
|
/backport to stable29 |
| }) | ||
| }) | ||
|
|
||
| it('deleted groups are removed from shares', () => { |
There was a problem hiding this comment.
For PHP code its more common to add integration tests (behat) that Cypress.
|
Is that different from #51000 ? |
provokateurin
left a comment
provokateurin
left a comment
There was a problem hiding this comment.
I'd prefer my PR, because it also fixes users getting removed from groups.
provokateurin
left a comment
provokateurin
left a comment
There was a problem hiding this comment.
Blocking, at least because the fix is incomplete.
|
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! (If you believe you should not receive this message, you can add yourself to the blocklist.) |
5 participants
Summary
group-deleted.cy.ts.mp4
Checklist