feat(setupcheck): check logging level for validity#50927
Merged
Conversation
Altahrim
approved these changes
Feb 20, 2025
susnux
commented
Feb 20, 2025
come-nc
reviewed
Feb 20, 2025
Contributor
come-nc
left a comment
come-nc
left a comment
There was a problem hiding this comment.
Could be merged with nextcloud/server/apps/settings/lib/SetupChecks/DebugMode.php ?
Contributor
Author
Could yes, but it does also check the logging level format which is not about debug mode, so probably two distinct checks |
skjnldsv
approved these changes
Feb 21, 2025
joshtrichards
approved these changes
Feb 21, 2025
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
susnux
force-pushed
the
feat/setup-check-logging
branch
from
bfbb847 to
f91db18
Compare
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
0) or when set to an invalid value #50885go.phplink for admin logging documentation#12745Check for log level validity to detect issues before they happen.
Checklist