fix(SharedStorage): Check if storage ID is set on cache

[solracsf]

• Resolves: [Bug]: Undefined array key "storage_string_id" at /apps/files_sharing/lib/SharedStorage.php#483 #50235

Summary

Else handle cache updating by the share source

Checklist

• Code is properly formatted
• Sign-off message is added to all commits
• Tests (unit, integration, api and/or acceptance) are included
• Screenshots before/after for front-end changes
• Documentation (manuals or wiki) has been updated or is not required
• Backports requested where applicable (ex: critical bugfixes)

[ChristophWurst]

I'm not an expert for file sharing but this looks sane and like a good hardening 👍

[susnux]

Running nextcloud 30.0.5

Yes because the parameter is incompatible on 30. You need to remove the array before $parameters

[gonzalo]

I will try but... commit should be adapted depending on nextcloud version?

[solracsf]

I will try but... commit should be adapted depending on nextcloud version?

Yes, dont replace a file from different branches. You can always apply the patch:
https://patch-diff.githubusercontent.com/raw/nextcloud/server/pull/50769.patch
https://www.cyberciti.biz/faq/appy-patch-file-using-patch-command/

But, if you're not familiar with these, just wait for an official and released version please (recommended).

[inDane]

I will try but... commit should be adapted depending on nextcloud version?

Yes, dont replace a file from different branches. You can always apply the patch: https://patch-diff.githubusercontent.com/raw/nextcloud/server/pull/50769.patch https://www.cyberciti.biz/faq/appy-patch-file-using-patch-command/

But, if you're not familiar with these, just wait for an official and released version please (recommended).

I've tried this for Nxcl 29.0.11.1 but i think the patch is for nextcloud 30, right? Because for me it failed. Just a heads up for others.

[solracsf]

/backport to stable31

[solracsf]

/backport to stable30

[solracsf]

/backport to stable29