fix(files_reminders): Only allow updating reminders if the file is accessible#50711
Merged
AndyScherzinger merged 3 commits intomasterfrom Feb 20, 2025
Merged
fix(files_reminders): Only allow updating reminders if the file is accessible#50711AndyScherzinger merged 3 commits intomasterfrom
AndyScherzinger merged 3 commits intomasterfrom
Conversation
Pytal
requested review from
ArtificialOwl,
artonge and
sorbaugh
and removed request for
a team
artonge
approved these changes
Feb 10, 2025
come-nc
approved these changes
Feb 11, 2025
…cessible Signed-off-by: Christopher Ng <chrng8@gmail.com>
…ng reminders Signed-off-by: Christopher Ng <chrng8@gmail.com>
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
AndyScherzinger
force-pushed
the
fix/reminder-node-access
branch
from
f101e69 to
fd591b0
Compare
icewind1991
reviewed
Apr 25, 2025
| * @throws DoesNotExistException | ||
| */ | ||
| public function getDueForUser(IUser $user, int $fileId): RichReminder { | ||
| $this->checkNode($user, $fileId); |
Member
There was a problem hiding this comment.
This causes a getFirstNodeById for every file in a folder when doing propfind which will lead to some pretty bad performance regression.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
No changes should be made for inaccessible files
Checklist