fix(DnsPinMiddleware): Don't log misleading port value / log request port instead

[joshtrichards]

• Resolves: https://help.nextcloud.com/t/oauth2-openid-discovery-endpoint-nextcloud-omits-to-connect-via-https-and-uses-port-80/216182/4

Summary

#43650 added logging of the host that triggers the LocalServerException. It also added the port to that log output.

However the logged port is misleading and logging it does not make sense in this context because... it's not the actual port specified in the request.

The port here is merely the one that happens to be the current one in the foreach iterator when the IP in question triggers isLocalAddress($ip) to be true. (We check a list of ports that is essentially {requestPort + 80 + 443}. Ultimately that'll be 80 every time which, again, has nothing to do with the current request.

So either don't log any port or, since we do have the request port, go ahead and log it for the admin since it's more relevant.

P.S. Hmm. Actually upon reflection I think we can probably just move the entire foreach ($ports as $port) { below the isLocalAddress() check too. The ports list is only used for properly populating the CURLOPT_RESOLVE. The ports themselves are not used for the check itself so no reason to run the check within the port combo iterator.

server/lib/private/Http/Client/DnsPinMiddleware.php

Lines 132 to 133 in a1be491

	foreach ($ports as $port) {
	$curlResolves["$hostName:$port"] = [];

TODO

• ...

Checklist

• Code is properly formatted
• Sign-off message is added to all commits
• Tests (unit, integration, api and/or acceptance) are included
• Screenshots before/after for front-end changes
• Documentation (manuals or wiki) has been updated or is not required
• Backports requested where applicable (ex: critical bugfixes)

[joshtrichards]

/backport to stable31

[joshtrichards]

/backport to stable30

[joshtrichards]

/backport to stable29

[Altahrim]

I think it makes sense to do what's in your "P.S.": check IP addresses first and populates curl options later.
It could allow to fix the TODO too, maybe in a second time