fix(files): Correctly scroll selected file into view

[susnux]

• Resolves: #

Summary

1. We did not consider the files filter height for the calculation
2. Initialize height variables before using them for scrolling - and wait for tbody styles to be updated.
3. Fixed condition to skip scrolling if there are less rows available then the current viewport can render.
4. Correctly clamp index we can scroll to when we reach the end of the scrollable area.

There is a slight change in design:
We scroll in such a way now that users see half of the previous row. The previous indented behavior was to see one and a half rows.
Reasons:

1. In grid mode the selected row is hard to spot on small screens
2. (IMHO) it is generally better to directly show the user the row directly (while keeping half a row on top to clarify the list is scrolled)

⬆️ we can discuss this change and drop it if preferred.

Screenshots

This is the scrolling position when having 11 files (0 to 10) and scrolling to index N:

Selected file (index)	🖼️
0
1
2
3
4
5
6
7
8,9,10 (same for all)

Checklist

• Code is properly formatted
• Sign-off message is added to all commits
• Tests (unit, integration, api and/or acceptance) are included
• Screenshots before/after for front-end changes
• Documentation (manuals or wiki) has been updated or is not required
• Backports requested where applicable (ex: critical bugfixes)

[susnux]

/compile

[skjnldsv]

We scroll in such a way now that users see half of the previous row. The previous indented behavior was to see one and a half rows.

Good for me!! 👍

[skjnldsv]

On your screenshots, why is the row not active ?
If the fileid is selected, it should be.

Is this a screenshot glitch ? Or is it broken ? (because it was working not too long ago 🙈 )

[susnux]

Is this a screenshot glitch ? Or is it broken ?

Screenshot glitch 🙈
Confirmed it is still working ✅

[susnux]

/backport to stable31

[susnux]

/backport to stable30

[susnux]

/backport to stable31