fix(files): Fix folder preview for favorites widget#50576
Merged
provokateurin merged 1 commit intomasterfrom Feb 3, 2025
Merged
fix(files): Fix folder preview for favorites widget#50576provokateurin merged 1 commit intomasterfrom
provokateurin merged 1 commit intomasterfrom
Conversation
Member
Author
|
/backport to stable31 |
Contributor
👍 I think if the fallback was requested then we should also add that fallback (folder icon). |
Member
Author
|
Ok, then I will add this as an enhancement on master, but not backport it as a fix for 31. |
susnux
reviewed
Jan 31, 2025
susnux
approved these changes
Jan 31, 2025
e3d61a5 to
ea68ad6
Compare
come-nc
approved these changes
Feb 3, 2025
Signed-off-by: provokateurin <kate@provokateurin.de>
ea68ad6 to
6ada9dd
Compare
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Folders don't have a preview and result in 404.
Alternatively we could change the endpoint to also generate "previews" for folders when mimeFallback=true.
That would make it more robust overall which would be nice.
Checklist