perf(files): Check node type property instead of instance#50553
Merged
perf(files): Check node type property instead of instance#50553
Conversation
Signed-off-by: Christopher Ng <chrng8@gmail.com>
Pytal
requested review from
nfebe,
skjnldsv and
szaimen
and removed request for
a team
Member
Author
|
/compile |
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
susnux
approved these changes
Jan 30, 2025
Contributor
susnux
left a comment
susnux
left a comment
There was a problem hiding this comment.
Have you measured it?
instanceof also is basically just a comparison of the prototype property.
But I agree with this changes also because sometimes if you bundle in a second nc-files library you endup with different prototypes so the instance check will fail.
Meaning to be save here we should not use the instanceof especially when nodes can come from apps.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Switch to faster property check
Checklist