fix: Correctly return app id and app version for core styles and images#50398
Merged
fix: Correctly return app id and app version for core styles and images#50398
core styles and images#50398Conversation
AndyScherzinger
approved these changes
Jan 24, 2025
…ages Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
susnux
force-pushed
the
fix/get-version-of-core
branch
from
03e2dbe to
31664b3
Compare
ChristophWurst
approved these changes
Jan 24, 2025
Member
ChristophWurst
left a comment
ChristophWurst
left a comment
There was a problem hiding this comment.
Makes sense while it also feels a tiny bit wrong to treat core as an app. I'd favor adjusting the caller to not look for an app version for appid=core but query ServerVersion directly
Contributor
Author
|
Yes but better safe than sorry (we also have many other places that treat core as an app) |
Member
|
Fair enough |
Contributor
Author
|
✅ Tests included |
ChristophWurst
approved these changes
Jan 24, 2025
susnux
force-pushed
the
fix/get-version-of-core
branch
from
026b8d7 to
3abb708
Compare
juliusknorr
approved these changes
Jan 24, 2025
Member
juliusknorr
left a comment
juliusknorr
left a comment
There was a problem hiding this comment.
More complete then my quick patch and has tests 👍 ❤️
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
susnux
force-pushed
the
fix/get-version-of-core
branch
from
3abb708 to
eea91fa
Compare
Contributor
Author
|
/backport to stable31 |
Contributor
Author
|
/backport to stable30 |
This was referenced Jan 24, 2025
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make sure that assets loaded from
core/cssandcore/imgare correctly assigned the server version.