Skip to content

[stable29] fix(files): actions submenu papercuts#50124

Merged
skjnldsv merged 3 commits intostable29from
backport/50123/stable29
Jan 22, 2025
Merged

[stable29] fix(files): actions submenu papercuts#50124
skjnldsv merged 3 commits intostable29from
backport/50123/stable29

Conversation

@backportbot
Copy link

@backportbot backportbot bot commented Jan 10, 2025 •
edited by skjnldsv
Loading

Pulled from #50123
Backport of #50126

  • Fix an issue where you would still have the previous opened submenu when opening another file's actions menu
  • Use Back to go back one menu up instead of the previous way (raised by @ShGKme, approved by @marcoambrosini)
Before After
image image

@backportbot backportbot bot requested a review from skjnldsv January 10, 2025 11:43
@backportbot backportbot bot added 3. to review Waiting for reviews feature: files labels Jan 10, 2025
@backportbot backportbot bot added this to the Nextcloud 29.0.11 milestone Jan 10, 2025
@skjnldsv skjnldsv changed the title [stable29] feat(api): File conversion Files action [stable29] fix(files): actions submenu papercuts Jan 10, 2025
@skjnldsv skjnldsv force-pushed the backport/50123/stable29 branch from cb72483 to cf84de8 Compare January 10, 2025 11:46
@skjnldsv skjnldsv marked this pull request as ready for review January 10, 2025 11:47
@skjnldsv skjnldsv force-pushed the backport/50123/stable29 branch from cf84de8 to a39a7d0 Compare January 10, 2025 11:47
@skjnldsv skjnldsv requested review from a team, Pytal, artonge, marcoambrosini, sorbaugh and susnux and removed request for a team and sorbaugh January 10, 2025 11:47
@skjnldsv skjnldsv added bug papercut Annoying recurring UX issue with possibly simple fix. labels Jan 10, 2025
@skjnldsv
Copy link
Member

skjnldsv commented Jan 22, 2025

/compile rebase

@skjnldsv skjnldsv added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Jan 22, 2025
skjnldsv and others added 3 commits January 22, 2025 08:22
@skjnldsv @nextcloud-command
fix(files): close submenu on main actions state change
a2d6ad8 
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
@skjnldsv @nextcloud-command
fix(files): rename actions submenu back entry
addc56a 
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
@nextcloud-command
chore(assets): Recompile assets
10e126c 
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@skjnldsv skjnldsv merged commit 2b3794c into stable29 Jan 22, 2025
113 checks passed
@skjnldsv skjnldsv deleted the backport/50123/stable29 branch January 22, 2025 08:52
@Altahrim Altahrim mentioned this pull request Feb 5, 2025
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@skjnldsv skjnldsv skjnldsv approved these changes

@ShGKme ShGKme ShGKme approved these changes

@marcoambrosini marcoambrosini marcoambrosini approved these changes

@artonge artonge Awaiting requested review from artonge artonge was automatically assigned from nextcloud/server-frontend

@susnux susnux Awaiting requested review from susnux

@Pytal Pytal Awaiting requested review from Pytal

Assignees

@skjnldsv skjnldsv

Labels

4. to release Ready to be released and/or waiting for tests to finish bug feature: files papercut Annoying recurring UX issue with possibly simple fix.

Projects

None yet

Milestone

Nextcloud 29.0.12

Development

Successfully merging this pull request may close these issues.

5 participants

@skjnldsv @ShGKme @marcoambrosini @solracsf @nextcloud-command