fix(AppFramework): Log malformed protocol values and unify fallback behavior#50099
Merged
fix(AppFramework): Log malformed protocol values and unify fallback behavior#50099
Conversation
f2d00fe to
892eb7d
Compare
892eb7d to
6b84508
Compare
skjnldsv
reviewed
Aug 1, 2025
skjnldsv
approved these changes
Aug 1, 2025
b2cc2b0 to
c2cf24c
Compare
sorbaugh
approved these changes
Aug 1, 2025
f511401 to
3fce359
Compare
…ehavior Signed-off-by: Josh <josh.t.richards@gmail.com>
Signed-off-by: John Molakvoæ <skjnldsv@users.noreply.github.com>
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
3fce359 to
d2a20ea
Compare
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ActivityNotFoundException: No Activity found to handle Intent { act=android.intent.action.VIEWandroid#14306No Activity found to handle Intent { act=android.intent.action.VIEW dat=HTTP:android#14474While the above are configuration matters so they're now closed, we can handle it better here in
serverwhich is that this PR proposes.Summary
This PR:
httpat a minimum).We currently:
http) when a malformed protocol value is received from a reverse proxy (viaX-Forwarded-Proto).overwriteprotocolto be reasonable.overwriteprotocolvalues (unlikeX-Forwarded-Proto).The fallback is not a default value. It's just means a reasonable protocol is returned. When the fallback is used, it's basically an error. If it wasn't existing behavior, we might consider throwing an exception here instead. This PR just adds similar fallback behavior for malformed
overwriteprotocolvalues and also logs when the fallback is used.Details:
overwriteprotocol(if any) and when malformed uses same fallback value (http) as we do forX-Forwarded-ProtoHTTP/HTTPS) as valid foroverwriteprotocol(just as it already does forX-Forwarded-Proto)TODO
Checklist