Fix broken taskprocessing api /tasktypes endpoint#50094
Merged
Conversation
Merged
marcelklehr
approved these changes
Jan 9, 2025
kyteinsky
approved these changes
Jan 9, 2025
oleksandr-nc
approved these changes
Jan 9, 2025
Contributor
Maybe we need a more precise CODEOWNERS file so that this can be done automatically? (it's hard to remember who is responsible for which file and everyone needs to remember it, which is almost impossible) |
Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
julien-nc
force-pushed
the
fix/noid/broken-taskprocessing-api
branch
from
bab6afa to
7bf74f9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reported by @alperozturk96 💙
The
/ocs/v2.php/taskprocessing/tasktypeswas broken by #49015 which changed objects into arrays in theinputShape,outputShape,optionalInputShapeetc...@provokateurin Please put at least @marcelklehr or me as reviewers when making such changes.