fix: block moving files to it's own parent with dav#49966
Merged
Conversation
icewind1991
requested review from
a team,
ArtificialOwl,
nfebe and
sorbaugh
and removed request for
a team
icewind1991
force-pushed
the
block-dav-move-parent
branch
2 times, most recently
from
1da0cb5 to
85dd1b2
Compare
This comment was marked as resolved.
This comment was marked as resolved.
4 tasks
icewind1991
force-pushed
the
block-dav-move-parent
branch
from
85dd1b2 to
4708472
Compare
Signed-off-by: Robin Appelman <robin@icewind.nl>
icewind1991
force-pushed
the
block-dav-move-parent
branch
from
4708472 to
9193cd6
Compare
solracsf
approved these changes
Jan 4, 2025
st3iny
approved these changes
Jan 4, 2025
Contributor
|
/backport to stable30 |
Contributor
|
/backport to stable29 |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently this leads to data loss as sabre will remove the target, and thus also the source, before doing the move
closes #49621