fix: restore updated encrypted version when copying versions#49903
Merged
fix: restore updated encrypted version when copying versions#49903
Conversation
icewind1991
requested review from
a team,
ArtificialOwl,
artonge and
yemkareems
and removed request for
a team
come-nc
approved these changes
Dec 19, 2024
Contributor
come-nc
left a comment
come-nc
left a comment
There was a problem hiding this comment.
I confirm this fixes versions compatibility with encryption.
It would be good to add an e2e test for this though.
Signed-off-by: Robin Appelman <robin@icewind.nl>
icewind1991
force-pushed
the
encryption-version-version
branch
from
811d634 to
012a402
Compare
Contributor
During my testing it seemed unnecessary as the version was supposed to by copied during the cache copy. But fine to keep it if needed. |
artonge
approved these changes
Jan 6, 2025
Contributor
|
/backport to stable30 |
Contributor
|
/backport to stable29 |
Contributor
|
#48651 was backported to stable30 and stable29 in February 2025. Therefore, we need this fix as well. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was removed with #48651 but breaks encrypted versions.
@artonge do you remember why you removed it?