feat(ocp): calendar event builder api#49888
Merged
nickvergessen merged 3 commits intomasterfrom Jan 8, 2025
Merged
Conversation
Member
Author
|
@nickvergessen This should get you started for the meetings feature. Let me know if you have questions. |
Member
Author
|
I added a example on how to use the |
3132ecd to
b9fbef9
Compare
3e6899c to
ce5b8a8
Compare
Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
ce5b8a8 to
80bc1c2
Compare
ChristophWurst
approved these changes
Jan 7, 2025
nickvergessen
approved these changes
Jan 7, 2025
Member
nickvergessen
left a comment
There was a problem hiding this comment.
Looks good, will implement Talk's side now
| return $this; | ||
| } | ||
|
|
||
| public function setSummary(string $summary): ICalendarEventBuilder { |
Member
There was a problem hiding this comment.
Is there a max length that we should check, or does caldav take care of that, same for description?
4 tasks
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
st3iny
commented
Jul 23, 2025
Comment on lines
+112
to
+116
| public function createInCalendar(ICreateFromString $calendar): string { | ||
| $fileName = $this->uid . '.ics'; | ||
| $calendar->createFromString($fileName, $this->toIcs()); | ||
| return $fileName; | ||
| } |
Member
Author
There was a problem hiding this comment.
The API is problematic: The event builder should build events/ICS files and not create events in calendars.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The event builder API is done and ready to use.
Code example
TODO
Actually implement the availability API(ref Schedule meetings inside Talk calendar#6516 (comment))Checklist