Disable/hide share edit options when user can not edit the share#49747
Disable/hide share edit options when user can not edit the share#49747
Conversation
|
/backport to stable30 |
|
/backport to stable29 |
|
/backport to stable28 |
|
/backport to stable27 |
|
/compile |
Signed-off-by: provokateurin <kate@provokateurin.de>
… can not edit share Signed-off-by: provokateurin <kate@provokateurin.de>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
e9e6af8 to
3a64092
Compare
|
The backport to # Switch to the target branch and update it
git checkout stable27
git pull origin stable27
# Create the new backport branch
git checkout -b backport/49747/stable27
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 1e44c671 f2898df2 3a640929
# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/49747/stable27Error: No changes found in backport branch Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports. |
|
/backport to stable30 |
|
/backport to stable28 |
|
The backport to # Switch to the target branch and update it
git checkout stable30
git pull origin stable30
# Create the new backport branch
git checkout -b backport/49747/stable30
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 1e44c671 f2898df2 3a640929
# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/49747/stable30Error: Failed to create pull request: Validation Failed: {"resource":"PullRequest","code":"custom","message":"A pull request already exists for nextcloud:backport/49747/stable30."} Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports. |
|
The backport to # Switch to the target branch and update it
git checkout stable28
git pull origin stable28
# Create the new backport branch
git checkout -b backport/49747/stable28
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 1e44c671 f2898df2 3a640929
# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/49747/stable28Error: Failed to create pull request: Validation Failed: {"resource":"PullRequest","code":"custom","message":"A pull request already exists for nextcloud:backport/49747/stable28."} Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports. |
Summary
We were still showing the user the options to edit and delete the share, but they will face an unhelpful error message when they try to continue.
Before:

After:

We could also hide the quick edit button, but I think it's nice to leave it there to still indicate the permission of the share, even if the current user can not change them.
Checklist