Handle tags with the same name gracefully#49674
Closed
Conversation
It's possible that tags with the same category exist with different ids because there's no unique index on the database. How to reproduce: - Remove the favorite tag - Select 2 or more files - Tag as favorite (with the batch action) Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
Merged
Member
|
What's the status @kesselb ? |
Member
|
Ping @kesselb 🙇 |
Contributor
Author
|
Huhu, sorry for not getting back to you earlier 🙈 I realized while working on it that adding that index on existing systems and ironing out the various issues I ran into while diving through the code needs more work. So I had the idea to hand it over to the files team. However, I don’t remember if I actually spoke with Christoph about it. I let him know now. |
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
We received a report that some files marked as favorites are not displayed in the "Favorites" view. Additionally, users cannot remove the favorite state from these files. This issue is similar to #49395.
Root Cause
Proposed Solution
To avoid requiring a migration path for existing tags, I adjusted the code to handle tags with the same name gracefully.
Commit: "vobjects may contain the same tag with different ids"
Commit: "add mapper for vcategory_to_object"
Current Status
The implementation requires additional work to fully resolve the deletion issue. However, due to higher-priority tickets, we are unable to allocate further time to this effort at the moment.
Checklist