fix(files_versions): fix undefined success message

[skjnldsv]

Fix weird error messages and improve layout by displaying empty label placeholder

[skjnldsv]

/backport to stable30

[skjnldsv]

/backport to stable29

[come-nc]

• Fixes [Bug]: "undefined restored" when restoring a previous version of a file #37055

[Pytal]

iirc it was a design decision to not show a label when not named @artonge @nimishavijay?

[skjnldsv]

iirc it was a design decision to not show a label when not named @artonge @nimishavijay?

It honestly looks weird without. It feels like a bug where some part of the UI is missing.
Especially between Initial version and Current Version

[Wendy-Russo]

i tried your branch using the command and the notification still shows undefined

[nimishavijay]

It was indeed a deliberate decision! :) most versions are not saved, so if they had a generic name the version list would just have many many duplicated "Unnamed version" labels. For versions that are not saved I'd keep then unnamed but use a more distinct identifier for the toast message, like the date ("Version from 10 days ago restored") :)

[come-nc]

It was indeed a deliberate decision! :) most versions are not saved, so if they had a generic name the version list would just have many many duplicated "Unnamed version" labels. For versions that are not saved I'd keep then unnamed but use a more distinct identifier for the toast message, like the date ("Version from 10 days ago restored") :)

I agree with @skjnldsv that this looks like a bug when looking at the UI like in #49664 (comment) .
If this is a blocker we should revert this part of the PR and still merge the rest because the current toast message with undefined is definitely problematic and has been reported by customers.

[jancborchardt]

As @nimishavijay saod, it is intentional to only highlight versions with a name, as they likely are important.

Highlighting all versions and naming them "Unnamed version" makes everything important (and thus nothing), makes it seem like you are forced to name every version, and makes it look unfinished.

For unnamed versions, we could say "Edited by [account bubble]", but not bold that. Only bold specifically named versions.

[skjnldsv]

"Edited by [account bubble]", but not bold that.

Good alternative, thanks Nimisha and Jan! 👍