perf: use more optimized way to get user storage info in ocs user info#49476
Merged
icewind1991 merged 1 commit intomasterfrom Jan 16, 2025
Merged
perf: use more optimized way to get user storage info in ocs user info#49476icewind1991 merged 1 commit intomasterfrom
icewind1991 merged 1 commit intomasterfrom
Conversation
icewind1991
requested review from
a team,
artonge,
come-nc and
yemkareems
and removed request for
a team
icewind1991
force-pushed
the
ocs-user-info-quota-optimize
branch
2 times, most recently
from
1706c3e to
e004ce7
Compare
yemkareems
approved these changes
Nov 26, 2024
come-nc
reviewed
Nov 26, 2024
Contributor
come-nc
left a comment
come-nc
left a comment
There was a problem hiding this comment.
quota_include_external_storage is no longer read, is that a regression?
Also, lastSeenQuotaUsage is no more updated, we could fill it with the computed quota, I think?
icewind1991
force-pushed
the
ocs-user-info-quota-optimize
branch
from
e004ce7 to
a4ed1b0
Compare
Member
Author
made it fallback to the old implementation when |
icewind1991
force-pushed
the
ocs-user-info-quota-optimize
branch
3 times, most recently
from
906b89b to
5958fcc
Compare
come-nc
reviewed
Jan 6, 2025
come-nc
reviewed
Jan 6, 2025
icewind1991
force-pushed
the
ocs-user-info-quota-optimize
branch
from
5958fcc to
1a913a8
Compare
…o when possible Signed-off-by: Robin Appelman <robin@icewind.nl>
icewind1991
force-pushed
the
ocs-user-info-quota-optimize
branch
from
1a913a8 to
118ff88
Compare
Merged
Merged
come-nc
approved these changes
Jan 16, 2025
Contributor
|
/backport to stable30 |
Contributor
|
/backport to stable29 |
Contributor
|
/backport to stable28 |
2 tasks
This was referenced Jan 16, 2025
Merged
4 tasks
come-nc
added
the
pending documentation
Contributor
|
Canceling the backports as this contain a subtle behavior change of the API. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of doing a full setup etc. We just get quota directly from the user, and the used space directly from the cache.
This means that we only need to setup the home storage for any user, instead of all storages the user has access to.
This does lead to a minor change in behavior, that for users with unlimited quota, the reported quota no longer falls back to the free space in the data directory. As far as I can tell these fields aren't used in the accounts ui and that behavior isn't something that can be relied on anyway, since s3 based setups (and various others) won't have this behavior anyway.