fix: invalid usage of IQueryBuilder::createNamedParameter()#49454
Merged
ChristophWurst merged 2 commits intomasterfrom Nov 25, 2024
Merged
fix: invalid usage of IQueryBuilder::createNamedParameter()#49454ChristophWurst merged 2 commits intomasterfrom
ChristophWurst merged 2 commits intomasterfrom
Conversation
And fix a typo: chunck -> chunk Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
st3iny
added
bug
3. to review
st3iny
requested review from
SebastianKrupinski and
tcitworld
as code owners
Member
Author
|
/backport to stable30 |
Member
Author
|
/backport to stable29 |
Member
Author
|
/backport to stable28 |
Contributor
|
He, can we cancel the back ports of this? I was just going to adjust the original backports. |
Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
st3iny
force-pushed
the
fix/invitations-named-parameter
branch
from
15a2c8e to
739ab5c
Compare
Member
Author
I'd say no. For consistency it is better to merge the other backports and then backport this PR. |
This was referenced Nov 23, 2024
SebastianKrupinski
approved these changes
Nov 23, 2024
ChristophWurst
approved these changes
Nov 25, 2024
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
I'm sorry, I missed some issues during my code review.
IQueryBuilder::createParameter().See also #49428 (comment)
Checklist