fix(status): Avoid session creation for status requests#49406
Merged
nickvergessen merged 1 commit intomasterfrom Nov 22, 2024
Merged
fix(status): Avoid session creation for status requests#49406nickvergessen merged 1 commit intomasterfrom
nickvergessen merged 1 commit intomasterfrom
Conversation
solracsf
requested review from
ChristophWurst,
juliusknorr and
nickvergessen
szaimen
reviewed
Nov 20, 2024
solracsf
force-pushed
the
avoidStatusSessions
branch
from
59d4d1d to
6140788
Compare
szaimen
reviewed
Nov 20, 2024
solracsf
force-pushed
the
avoidStatusSessions
branch
from
6140788 to
7395bfd
Compare
juliusknorr
approved these changes
Nov 21, 2024
nickvergessen
requested changes
Nov 21, 2024
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
solracsf
force-pushed
the
avoidStatusSessions
branch
from
85ccc8e to
33d7019
Compare
nickvergessen
approved these changes
Nov 21, 2024
Member
nickvergessen
left a comment
nickvergessen
left a comment
There was a problem hiding this comment.
But since we have a valid request class in the place already, it should be fine
Merged
Contributor
|
Hey, it looks like this broke the security scanner. See https://help.nextcloud.com/t/update-nextcloud-to-31-0-0-now-scaner-showing-rating-a/218485/13. So revert? |
Member
|
Requests from scanner 1/month or 1/year We can add a force header to do the session or we scan a second endpoint. |
Contributor
|
Resolved by #51184 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist