feat: Add first login timestamp of each user to oc_preferences and user:info output by come-nc · Pull Request #49377 · nextcloud/server

come-nc · 2024-11-19T14:06:22Z

See #22640
Close #48649

Summary

Add First login information in the user settings, as is done for last login

Add it to the UI
Decide how to handle migration

Checklist

Code is properly formatted
Sign-off message is added to all commits
Tests (unit, integration, api and/or acceptance) are included
Screenshots before/after for front-end changes
Documentation (manuals or wiki) has been updated or is not required
Backports requested where applicable (ex: critical bugfixes)

come-nc · 2024-11-21T15:07:06Z

Decide how to handle migration

I now store -1 for users which have already logged in before upgrade to 31, and show that as "unknown" in user:info output.

Pytal · 2024-12-05T23:51:52Z

✅ Add it to the UI

Pytal · 2024-12-05T23:55:48Z

core/Command/User/Info.php

 			'quota' => $user->getQuota(),
 			'storage' => $this->getStorageInfo($user),
-			'last_seen' => date(\DateTimeInterface::ATOM, $user->getLastLogin()), // ISO-8601
+			'first_seen' => $firstSeen,


Checked user:info first_seen and looks good 👍

Can we also show this in user:list --info?

Added.

But I’m remembering now that last time a PR tried to show never for last_seen @nickvergessen objected that this was a breaking change.
So not sure what is the best way ahead here. It is not appropriate to show fake timestamp for never/unknown, on the other hand scripts need to be aware of it.
Maybe we simply note this as a breaking change and still merge the change?

Added.

Tested, thanks 🙏

come-nc · 2024-12-09T09:54:30Z

/compile /

come-nc · 2024-12-09T10:30:43Z

✅ Add it to the UI

Can you change the order to have first login before last login? Both in columns and settings. It’s disturbing to have last first.

apps/provisioning_api/lib/Controller/AUserData.php

ChristophWurst · 2024-12-16T16:31:57Z

lib/public/IUser.php


 	/**
-	 * updates the timestamp of the most recent login of this user
+	 * Returns the timestamp of the user's first login, 0 if the user did never login, or -1 if the data is unknown (first login was on an older version)


nit: int|null|false could make the three possible outcomes more explicit, and prevent someone from using the magic numbers for any kind of calculations.

come-nc · 2024-12-19T09:29:41Z

/compile /

come-nc · 2025-01-07T09:37:21Z

/compile /

…er:info output Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>

…urrent date Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>

Signed-off-by: Christopher Ng <chrng8@gmail.com>

Also format unknown and never in a better way. Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>

Co-authored-by: Joas Schilling <213943+nickvergessen@users.noreply.github.com> Signed-off-by: Côme Chilliet <91878298+come-nc@users.noreply.github.com>

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>

come-nc · 2025-01-07T15:30:55Z

/compile /

Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>

nickvergessen · 2025-01-08T08:36:31Z

lib/public/IUser.php

+	 *
+	 * @since 31.0.0
+	 */
+	public function getFirstLogin(): int;


This and the above/below change will break all 3rdparty user backends?

Same as getPasswordHash/setPasswordHash below did for 30.

But actually no, most apps do not implement IUser.
I see those:

lib/private/Remote/User.php:class User implements IUser {

lib/private/User/LazyUser.php:class LazyUser implements IUser {

lib/private/User/User.php:class User implements IUser {

apps/notifications/lib/FakeUser.php:class FakeUser implements IUser {

apps-extra/groupfolders/tests/stubs/oc_user_user.php:class User implements IUser {

apps-extra/guests/tests/stub.php: class User implements IUser {

So only notifications implements it.

Right, I mixed it up with the backends, I thought each backend implements their own IUser, but seems to not be the case.

marcoambrosini · 2025-01-20T13:57:45Z

@Pytal one comment about the UI, could we remove the seconds count?

Pytal · 2025-01-21T22:03:58Z

@Pytal one comment about the UI, could we remove the seconds count?

Done #50305 :)

come-nc requested a review from provokateurin as a code owner November 19, 2024 14:06

come-nc self-assigned this Nov 19, 2024

come-nc added the 2. developing Work in progress label Nov 19, 2024

come-nc added this to the Nextcloud 31 milestone Nov 19, 2024

come-nc force-pushed the enh/add-first-login-timestamp branch from eb486cc to fd366a6 Compare November 21, 2024 15:06

come-nc force-pushed the enh/add-first-login-timestamp branch from fd366a6 to f8c42b7 Compare December 3, 2024 09:20

Pytal reviewed Dec 5, 2024

View reviewed changes

Pytal self-assigned this Dec 5, 2024

nickvergessen reviewed Dec 9, 2024

View reviewed changes

apps/provisioning_api/lib/Controller/AUserData.php Outdated Show resolved Hide resolved

Pytal force-pushed the enh/add-first-login-timestamp branch from 159276f to f102154 Compare December 9, 2024 22:30

Pytal added enhancement feature: users and groups feature: occ labels Dec 9, 2024

come-nc force-pushed the enh/add-first-login-timestamp branch from f00a83d to 99ba7d3 Compare December 10, 2024 09:19

Pytal force-pushed the enh/add-first-login-timestamp branch from 6a68788 to 8f05db4 Compare December 10, 2024 18:03

Pytal added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Dec 10, 2024

Pytal approved these changes Dec 10, 2024

View reviewed changes

Pytal requested review from a team, artonge and icewind1991 and removed request for a team December 10, 2024 18:08

Pytal enabled auto-merge December 10, 2024 18:32

come-nc requested a review from nickvergessen December 12, 2024 10:12

ChristophWurst approved these changes Dec 16, 2024

View reviewed changes

ChristophWurst added the pending documentation This pull request needs an associated documentation update label Dec 16, 2024

come-nc added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Dec 19, 2024

sorbaugh disabled auto-merge December 20, 2024 08:12

come-nc force-pushed the enh/add-first-login-timestamp branch from 4f20a9b to c5d3aa1 Compare January 7, 2025 09:37

come-nc mentioned this pull request Jan 7, 2025

31.0.0 beta 1 #50066

Merged

come-nc force-pushed the enh/add-first-login-timestamp branch from e79ace7 to 60b2e22 Compare January 7, 2025 15:00

come-nc and others added 10 commits January 7, 2025 16:29

feat: Add first login timestamp of each user to oc_preferences and us…

baf7293

…er:info output Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>

chore: Update openapi specs

e700713

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>

fix(tests): Adapt tests to firstLogin new feature

df8397e

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>

feat(users): Use -1 for unknown firstLogin instead of setting it to c…

b995912

…urrent date Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>

feat: Show first login date in user list

c4b5a78

Signed-off-by: Christopher Ng <chrng8@gmail.com>

feat(occ): Show first_seen in output of user:list --info

1d0962a

Also format unknown and never in a better way. Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>

fix: Return timestamps in unix format rather than milliseconds

a8a2ca4

Co-authored-by: Joas Schilling <213943+nickvergessen@users.noreply.github.com> Signed-off-by: Côme Chilliet <91878298+come-nc@users.noreply.github.com>

fix(users): Adapt UI code to new timestamp fields names

9ada0bb

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>

chore: Update openapi.json files

0be1867

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>

fix(tests): Fix getLastLogin expectation in UsersControllerTest

de8c450

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>

come-nc force-pushed the enh/add-first-login-timestamp branch from 60b2e22 to de8c450 Compare January 7, 2025 15:30

chore(assets): Recompile assets

c45b9ec

Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>

Pytal merged commit 51c2582 into master Jan 7, 2025
188 checks passed

Pytal deleted the enh/add-first-login-timestamp branch January 7, 2025 17:17

nickvergessen reviewed Jan 8, 2025

View reviewed changes

sorbaugh added the 🍀 2025-Spring label Jan 15, 2025

Pytal mentioned this pull request Jan 21, 2025

chore: Only show hours and minutes in first login timestamp #50305

Merged

4 tasks

come-nc mentioned this pull request Apr 22, 2025

feat: Document new method IUser::getFirstLogin in upgrade guide nextcloud/documentation#13068

Merged

come-nc removed the pending documentation This pull request needs an associated documentation update label Apr 22, 2025

Uh oh!

Conversation

come-nc commented Nov 19, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Checklist

Uh oh!

come-nc commented Nov 21, 2024

Uh oh!

Pytal commented Dec 5, 2024

Uh oh!

Pytal Dec 5, 2024

Choose a reason for hiding this comment

Uh oh!

come-nc Dec 9, 2024

Choose a reason for hiding this comment

Uh oh!

Pytal Dec 9, 2024

Choose a reason for hiding this comment

Uh oh!

come-nc commented Dec 9, 2024

Uh oh!

come-nc commented Dec 9, 2024

Uh oh!

Uh oh!

ChristophWurst Dec 16, 2024

Choose a reason for hiding this comment

Uh oh!

come-nc commented Dec 19, 2024

Uh oh!

come-nc commented Jan 7, 2025

Uh oh!

come-nc commented Jan 7, 2025

Uh oh!

Uh oh!

nickvergessen Jan 8, 2025

Choose a reason for hiding this comment

Uh oh!

come-nc Jan 9, 2025

Choose a reason for hiding this comment

Uh oh!

nickvergessen Jan 9, 2025

Choose a reason for hiding this comment

Uh oh!

marcoambrosini commented Jan 20, 2025

Uh oh!

Pytal commented Jan 21, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants

come-nc commented Nov 19, 2024 •

edited

Loading