fix: Redirect user to login if session is terminated

[susnux]

• Resolves: [Bug]: Getting Unexpected error: Invalid response 401 in Files app #49187 (comment)

Summary

If a session timed out or was closed in another tab, then currently the user gets random error messages. This intercepts 401 responses (should only happen if logged out, or the users does something wrong).

If we get a 401, we make sure its because of the session, by checking if the user can access the files app.
If that is also the case we forward the user to the login page and set the redirect URL to the last used URL.

Screen recording

Bildschirmaufnahme_20241111_174951.webm

Checklist

• Code is properly formatted
• Sign-off message is added to all commits
• Tests (unit, integration, api and/or acceptance) are included
• Screenshots before/after for front-end changes
• Documentation (manuals or wiki) has been updated or is not required
• Backports requested where applicable (ex: critical bugfixes)

[susnux]

/backport to stable30

[susnux]

/backport to stable29

[artonge]

Shouldn't this be added to the @nextcloud/axios lib?
But is the webdav lib using @nc/axios?

[susnux]

Shouldn't this be added to the @nextcloud/axios lib?

No, similar as the other interceptors, this is not a feature developers can opt-in with using nc-axios, but it is a core feature.
Meaning it should work for all requests, even if you just use vanilla JavaScript.

[susnux]

Tests added.

[skjnldsv]

/compile

[inet-cologne]

@susnux , @skjnldsv , @artonge , @Pytal
Hey guys,
may it be that the change made here in #49560 or #49208 produces somehow login problems within Nextcloud files app, Nextcloud Talk app and perhaps causing issues with Calendar subscription synchronising?
Since a couple of days after updating (several instances!!) Nextcloud Server to 30.0.5, problems were occurring that Login fails. These could be fixed by deleting and reinstalling and reconfiguring the apps.
30.0.6 does not fix the situation either but now even reinstallation does not help anymore.
Login with the above mentioned iOS apps are not possible any more!!
Please see issue #50619!

Thanks for checking that!!
Chris

[inet-cologne]

@susnux , @skjnldsv , @artonge , @Pytal
Hey guys, could you pleeeease check this?
Thanks a lot!!

[jolly-jump]

@susnux , @skjnldsv , @artonge , @Pytal
Hey guys,

can you please check, if you are experiencing the login problems as well?
There are some github issues and forum-threads that seem to fit.
I did some summary: https://help.nextcloud.com/t/first-login-with-desktop-ios-android-app-fails/223854
I have no clue, why this happens to "us" and not to everyone as it seems.

Thanks!

[jolly-jump]

@susnux , @skjnldsv , @artonge , @Pytal Hey guys, could you pleeeease check this? Thanks a lot!!

Hi again,
I figured, that our login-rejection problem might be connected to using LDAP/AD as authenticator.

Can you rule out that your code changes here could lead to login-problem in combination with LDAP/AD? Did you test your changes with such a setting?

Thanks!