Fixing markdown parsing on settings#48798
Conversation
The custom renderer for heading on "marked" used fn(text,level). The documentation of marked gives a object of type "Heading"
interface Heading {
type: "heading";
raw: string;
depth: number;
text: string;
tokens: Token[];
}
Signed-off-by: Dennis Rehbehn <[email protected]>
|
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! (If you believe you should not receive this message, you can add yourself to the blocklist.) |
am-hachim
left a comment
am-hachim
left a comment
There was a problem hiding this comment.
I checked the content of your branch, and the changes have been made.
|
Fixed by #48852 |
5 participants
[object Object]show in place of headings on 'Your apps' page, app details panel, description tab #48661Summary
The custom markdown renderer heading for "marked" used fn(text,level).
In the docs it's this:
https://marked.js.org/using_pro
heading({ tokens, depth }: Tokens.Heading): string;
Before:
After:
TODO
Checklist