feat(systemtags): add bulk tagging action#48786
Merged
Conversation
skjnldsv
added
enhancement
2. developing
skjnldsv
force-pushed
the
feat/files-bulk-tagging
branch
3 times, most recently
from
dc9cbf5 to
14b2817
Compare
skjnldsv
force-pushed
the
feat/files-bulk-tagging
branch
3 times, most recently
from
02602f0 to
f69c5be
Compare
This comment was marked as resolved.
This comment was marked as resolved.
nextcloud-command
force-pushed
the
feat/files-bulk-tagging
branch
from
f69c5be to
e6bc4de
Compare
skjnldsv
force-pushed
the
feat/files-bulk-tagging
branch
3 times, most recently
from
9a86741 to
1e8dddc
Compare
skjnldsv
added
3. to review
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
…nces Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
skjnldsv
force-pushed
the
feat/files-bulk-tagging
branch
from
1e8dddc to
3e6d18a
Compare
skjnldsv
requested review from
a team,
nfebe,
provokateurin,
sorbaugh,
susnux and
szaimen
and removed request for
a team
provokateurin
approved these changes
Oct 29, 2024
Member
provokateurin
left a comment
provokateurin
left a comment
There was a problem hiding this comment.
PHP looks good to me, just a minor suggestion
| $table = $schema->getTable('systemtag'); | ||
|
|
||
| if (!$table->hasColumn('etag')) { | ||
| $table->addColumn('etag', 'string', [ |
Member
There was a problem hiding this comment.
Suggested change
| $table->addColumn('etag', 'string', [ | |
| $table->addColumn('etag', Types::STRING, [ |
susnux
approved these changes
Oct 29, 2024
skjnldsv
added
4. to release
This was referenced Oct 29, 2024
3 tasks
Merged
Contributor
|
I notice that when Tags are assigned or unassigned via this bulk tagging action, the Events MapperEvent::EVENT_ASSIGN, and MapperEvent::EVENT_UNASSIGN are not dispatched. This might cause problems with any apps which rely on it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #45935