[stable29] fix: Shipped apps should include the Nextcloud version in the cache buster#48700
Merged
[stable29] fix: Shipped apps should include the Nextcloud version in the cache buster#48700
Conversation
provokateurin
approved these changes
Oct 14, 2024
come-nc
approved these changes
Oct 15, 2024
Collaborator
|
CI error sounds related |
provokateurin
requested changes
Oct 30, 2024
Member
provokateurin
left a comment
provokateurin
left a comment
There was a problem hiding this comment.
Agreed, @susnux please take a look
Contributor
Author
Yes but it is super weird, not happening on master and can not reproduce locally... Will see. |
…uster Co-authored-by: Ferdinand Thiessen <opensource@fthiessen.de> Co-authored-by: Kate <26026535+provokateurin@users.noreply.github.com> Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
susnux
force-pushed
the
fix/cachebuster-stable30
branch
from
42aa766 to
9500984
Compare
provokateurin
approved these changes
Oct 30, 2024
Contributor
Author
|
✍️ todo for later: Move everything from that horrible constructor to the render function or similar. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Manual backport of #48650