fix(users): improve recently active search#48559
Merged
Conversation
Collaborator
Author
|
/backport to stable30 |
Altahrim
requested review from
a team,
ArtificialOwl,
artonge and
come-nc
and removed request for
a team
come-nc
approved these changes
Oct 7, 2024
Altahrim
force-pushed
the
fix/recently_active_pgsql
branch
from
787de53 to
efa4ea1
Compare
artonge
approved these changes
Oct 8, 2024
Altahrim
force-pushed
the
fix/recently_active_pgsql
branch
9 times, most recently
from
3287967 to
b0f7fe8
Compare
Altahrim
force-pushed
the
fix/recently_active_pgsql
branch
2 times, most recently
from
157fd45 to
22061d1
Compare
Altahrim
force-pushed
the
fix/recently_active_pgsql
branch
from
22061d1 to
b0e22ba
Compare
artonge
force-pushed
the
fix/recently_active_pgsql
branch
4 times, most recently
from
6f585ca to
9c11ec8
Compare
Altahrim
force-pushed
the
fix/recently_active_pgsql
branch
7 times, most recently
from
c463a32 to
cb83cef
Compare
Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
- Remove DISTINCT clause to fix PgSQL - Join user table only if necessary - Don't show people who never connected in active list - Add test Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
Altahrim
force-pushed
the
fix/recently_active_pgsql
branch
from
cb83cef to
49bd175
Compare
2 tasks
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TODO
Checklist