Merged
Conversation
9b38338 to
4e53ecc
Compare
kesselb
approved these changes
Oct 7, 2024
susnux
reviewed
Oct 7, 2024
come-nc
reviewed
Oct 7, 2024
come-nc
reviewed
Oct 7, 2024
4e53ecc to
998d972
Compare
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
…dparty bump) Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
…meterOption calls Signed-off-by: Joas Schilling <coding@schilljs.com>
998d972 to
315e465
Compare
come-nc
approved these changes
Oct 7, 2024
Contributor
@nickvergessen To be precise, I think we can with https://psalm.dev/docs/annotating_code/type_syntax/conditional_types/ , but it’s a bit complicated. Maybe we should simply add in Base: function getQuestionHelper(): QuestionHelper {
/** @var QuestionHelper */
return $this->getHelper('question');
}Seeing how often this is used. |
Member
Author
I'm up for that, if we add a public interface. I don't feel like typing 3rdparty with implied assumptions |
kesselb
added a commit
to kesselb/nextcloud-ocp
that referenced
this pull request
Oct 8, 2024
Follow up for nextcloud/3rdparty#1956 and nextcloud/server#48539 Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
Member
Author
|
/backport e6cd105 to stable29 |
Member
Author
|
/backport e6cd105 to stable28 |
1 task
1 task
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Checklist