fix(QueryBuilder): Account for aliases in output columns#48522
Merged
provokateurin merged 1 commit intomasterfrom Oct 3, 2024
Merged
fix(QueryBuilder): Account for aliases in output columns#48522provokateurin merged 1 commit intomasterfrom
provokateurin merged 1 commit intomasterfrom
Conversation
Signed-off-by: provokateurin <kate@provokateurin.de>
Member
Author
|
/backport to stable30 |
come-nc
approved these changes
Oct 3, 2024
Contributor
come-nc
left a comment
There was a problem hiding this comment.
Looks sane, did not test.
icewind1991
approved these changes
Oct 3, 2024
Member
icewind1991
left a comment
There was a problem hiding this comment.
Ideally we should discourage apps from doing aliases like this instead of using selectAlias
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
#48361 added error logs when the output column is too long. #48521 shows the output columns weren't extracted correctly as it contained
display_mode as display_mode_defaultwhich is actually fine becausedisplay_mode_defaultis only 20 chars.Checklist