fix broken app groups display#48504
Conversation
joshtrichards
added
bug
3. to review
Signed-off-by: Yannick Lescure <yannick.lescure@gmail.com>
yannicklescure
force-pushed
the
fix/select-groups-display
branch
from
6233162 to
258cb1a
Compare
come-nc
requested review from
a team,
Pytal,
susnux and
szaimen
and removed request for
a team
|
Hi @joshtrichards if you need me to change things in my PR, please let me know. |
|
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! (If you believe you should not receive this message, you can add yourself to the blocklist.) |
| this.appGroupsOptions = this.groups.filter((group) => !this.app.groups.includes(group)) | ||
| } | ||
| }) | ||
| .catch((err) => console.error('could not search groups', err)) |
There was a problem hiding this comment.
Please use the logger instead of the console
| return this.$store.getters.getGroups | ||
| .filter(group => group.id !== 'disabled') | ||
| .sort((a, b) => a.name.localeCompare(b.name)) | ||
| appGroups: { |
There was a problem hiding this comment.
Using a computed with setter that dispatches a store event is not really recommended. This should rather be handled in an event handler.
…nto fix/select-groups-display
…/nextcloud-server into fix/select-groups-display
susnux
requested review from
a team and
susnux
and removed request for
a team and
Pytal
|
Unfortunately, this pull request is outdated and no longer needed since #55901 was merged. With that being said, you are valued and we really appreciate the time spent on making this contribution. :) |
|
Thank you @elzody I appreciate the kind message. |
5 participants
Fix for issue #46634