refactor(Encryption): Migrate to strong types#48487
Merged
provokateurin merged 2 commits intomasterfrom Oct 7, 2024
Merged
Conversation
provokateurin
added
3. to review
Member
Author
|
Wrapper\Encryption has similar troubles, gonna fix that as well. |
provokateurin
changed the title
4 tasks
artonge
approved these changes
Oct 1, 2024
provokateurin
force-pushed
the
refactor/stream-encryption/typings
branch
from
9b32a61 to
73ca69d
Compare
come-nc
reviewed
Oct 3, 2024
Signed-off-by: provokateurin <kate@provokateurin.de>
provokateurin
force-pushed
the
refactor/stream-encryption/typings
branch
from
73ca69d to
8aceb68
Compare
Signed-off-by: provokateurin <kate@provokateurin.de>
provokateurin
force-pushed
the
refactor/stream-encryption/typings
branch
from
8aceb68 to
4412b2b
Compare
come-nc
approved these changes
Oct 7, 2024
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
I noticed that
if (!$this->storage->file_exists($this->internalPath)) {was called withnullas$internalPathwhich is not allowed.Added strong types and fixed the tests which were giving wrong/incomplete inputs.
Checklist