fix(migration): Check if column exits before adding it#48480
Conversation
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
|
/backport to stable30 |
szaimen
left a comment
There was a problem hiding this comment.
Makes sense! Can we somehow add a test for this so that such an if clause is never forgotten?
joshtrichards
left a comment
There was a problem hiding this comment.
Check makes sense, but I don't understand the state people are ending up in in that bug report: upgrading from v29 directly shouldn't have that column anyhow.
Integration testing focused on the the upgrade path should catch these (which we don't have AFAIK). Particularly if we had a matrix covering major->major, beta->major, rc->major, etc. |
Yet this is out of the scope of this specific PR, I fully agree on this. |
Checklist