refactor: Add void return type to PHPUnit test methods#48049
Merged
miaulalala merged 2 commits intomasterfrom Sep 15, 2024
Merged
refactor: Add void return type to PHPUnit test methods#48049miaulalala merged 2 commits intomasterfrom
miaulalala merged 2 commits intomasterfrom
Conversation
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
ChristophWurst
requested review from
miaulalala and
nickvergessen
as code owners
provokateurin
approved these changes
Sep 15, 2024
Member
provokateurin
left a comment
provokateurin
left a comment
There was a problem hiding this comment.
Nice, can we also do this for other return types in the future?
miaulalala
approved these changes
Sep 15, 2024
st3iny
approved these changes
Sep 15, 2024
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
For my OCD.
TODO
Checklist