fix(collaboration): Reduce timeouts to 3s for link reference connects#47948
Merged
nickvergessen merged 1 commit intomasterfrom Sep 16, 2024
Merged
fix(collaboration): Reduce timeouts to 3s for link reference connects#47948nickvergessen merged 1 commit intomasterfrom
nickvergessen merged 1 commit intomasterfrom
Conversation
Fixes rest of #34720 #34720 (comment) Signed-off-by: Josh <josh.t.richards@gmail.com>
Member
|
Member
|
I mean we can still reduce the seconds, but at least the memory problem is solved? |
Member
Author
Correct. Memory usage already addressed. Just dealing with the timeouts now so we can close that issue out entirely. |
skjnldsv
approved these changes
Sep 16, 2024
Member
|
We close or we merge then @joshtrichards ? :) |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes rest of #34720
See #34720 (comment)
Any timeout value is somewhat arbitrary. We're currently using 10s. Lowered to 3s for now.
Might be worth backporting to 30 just to more feedback from real world usage sooner, but otherwise probably doesn't matter at the moment.
TODO
Checklist