fix(files): Add more visual move / copy notification#47910
Merged
Conversation
susnux
requested review from
nfebe and
szaimen
and removed request for
a team
Contributor
Author
|
/backport to stable30 |
Contributor
Author
|
/backport to stable29 |
Contributor
Author
|
/backport to stable28 |
This comment was marked as resolved.
This comment was marked as resolved.
kesselb
reviewed
Sep 11, 2024
Member
marcoambrosini
left a comment
marcoambrosini
left a comment
There was a problem hiding this comment.
Very nice, can we use a loader component instead and feed the actual progress of the operation to it?
I had a mockup for something similar a few months ago, but this is a much simpler solution that does a big part of the job.
Member
That is much more work, and should be scheduled by a team lead :) |
susnux
commented
Sep 26, 2024
susnux
force-pushed
the
fix/files-add-move-info
branch
from
7fd28ce to
5571372
Compare
kesselb
approved these changes
Sep 30, 2024
Contributor
|
Thank you 👍 It's not ideal that for every selected file a toast is shown, but still better than before 🙏 |
marcoambrosini
approved these changes
Sep 30, 2024
* Resolves: #46645 This adds loading toast notification while the move operation is running. Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
kesselb
force-pushed
the
fix/files-add-move-info
branch
from
5571372 to
d97e17b
Compare
Contributor
|
Rebase + Recompile |
This was referenced Sep 30, 2024
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This adds loading toast notification while the move operation is running.
Screen recording
Bildschirmaufnahme_20240911_222420.webm
Checklist