fix(files_sharing): Open single-file-share by default#47841
Merged
Conversation
mejo-
approved these changes
Sep 9, 2024
Member
mejo-
left a comment
mejo-
left a comment
There was a problem hiding this comment.
Nice, tested and works well. Thanks for fixing this straight away ❤️
artonge
approved these changes
Sep 9, 2024
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
mejo-
force-pushed
the
fix/files-sharing-openfile
branch
from
2ae762f to
fccb132
Compare
Member
|
/compile |
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Bring back the behavior that single file shares open the viewer by default.
We can not use a redirect like internally, so we need to adjust the route in the front end by checking if it is a single-file-share and if yes request the files app to open it.
Checklist