fix(files_sharing): password checkbox and labels in link share#47807
Merged
fix(files_sharing): password checkbox and labels in link share#47807
Conversation
Contributor
Author
|
/backport to stable30 |
Contributor
Author
|
/backport to stable29 |
susnux
approved these changes
Sep 6, 2024
artonge
approved these changes
Sep 9, 2024
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
c6be59f to
692a8ed
Compare
Contributor
Author
|
Rebased on |
This was referenced Sep 9, 2024
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
In link share creation:
NcActionCheckboxcomponent wasn't imported and registered - fixedNcActionInputcontent was used instead of alabelprop - replacedNcActionTextin flavor oflabelScreenshots
Enforced date - worked but no accessible label
Enforced password - worked but no accessible label
Ask for a password - had no label at all and no checkbox to re-enable
Checklist