fix(appstore): Cache apps.json also on dev instances#47754
Merged
AndyScherzinger merged 1 commit intomasterfrom Sep 5, 2024
Merged
fix(appstore): Cache apps.json also on dev instances#47754AndyScherzinger merged 1 commit intomasterfrom
AndyScherzinger merged 1 commit intomasterfrom
Conversation
bigcat88
approved these changes
Sep 4, 2024
skjnldsv
approved these changes
Sep 4, 2024
Signed-off-by: Marcel Müller <marcel-mueller@gmx.de>
39b37d8 to
b2c2c93
Compare
provokateurin
approved these changes
Sep 5, 2024
Contributor
Author
|
/backport! to stable30 |
Contributor
Author
|
/backport! to stable29 |
Contributor
Author
|
/backport! to stable28 |
This was referenced Sep 5, 2024
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Currently caching of appstore files is disabled as soon as we are running
beta,dailyorgitchannel. When we run the current master and openindex.php/settings/apps/discoverwe hitserver/lib/private/App/AppStore/Fetcher/Fetcher.php
Lines 111 to 117 in 09fef8f
apps.jsonfrom the app store.While it makes sense to have a shorter cache time for dev instances, we shouldn't omit all caching. This PR adds a 15 min caching (instead of 60 min on production) to dev instances.
Checklist