fix: only keep major as server version#47709
Merged
Conversation
skjnldsv
requested review from
artonge and
sorbaugh
and removed request for
a team
Member
Author
|
/backport to stable30 |
Member
Author
|
/backport to stable29 |
Member
Author
|
/backport to stable28 |
Contributor
In an ideal world we would only compile on releases and never in between 😅 |
susnux
approved these changes
Sep 3, 2024
Contributor
susnux
left a comment
susnux
left a comment
There was a problem hiding this comment.
Should work, problem here is we do not do semantic versioning here, but currently this should not break anything.
blizzz
approved these changes
Sep 3, 2024
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
susnux
force-pushed
the
fix/server-webpack-appverson
branch
from
eb30995 to
3fe5faf
Compare
Contributor
|
/compile |
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
|
The backport to # Switch to the target branch and update it
git checkout stable28
git pull origin stable28
# Create the new backport branch
git checkout -b backport/47709/stable28
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 3fe5faf5 9763efa7
# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/47709/stable28Error: Failed to clone repository: Failed to checkout branches: Updating 1cc7851..b98b5bb
Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports. |
|
The backport to # Switch to the target branch and update it
git checkout stable29
git pull origin stable29
# Create the new backport branch
git checkout -b backport/47709/stable29
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 3fe5faf5 9763efa7
# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/47709/stable29Error: Failed to clone repository: Failed to checkout branches: Updating 1cc7851..b98b5bb
Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports. |
|
The backport to # Switch to the target branch and update it
git checkout stable30
git pull origin stable30
# Create the new backport branch
git checkout -b backport/47709/stable30
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 3fe5faf5 9763efa7
# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/47709/stable30Error: Failed to clone repository: Failed to checkout branches: Updating 1cc7851..b98b5bb
Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports. |
This comment was marked as resolved.
This comment was marked as resolved.
Member
Author
For some reason Github is not showing me merged PR... |
Member
Author
|
/backport to stable30 |
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
1 similar comment
This comment was marked as resolved.
This comment was marked as resolved.
|
The backport to # Switch to the target branch and update it
git checkout stable30
git pull origin stable30
# Create the new backport branch
git checkout -b backport/47709/stable30
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 3fe5faf5 9763efa7
# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/47709/stable30Error: fatal: ambiguous argument 'stable30': unknown revision or path not in the working tree. Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports. |
Member
Author
|
/backport to stable30 |
2 tasks
Member
Author
|
/backport to stable29 |
|
The backport to # Switch to the target branch and update it
git checkout stable29
git pull origin stable29
# Create the new backport branch
git checkout -b backport/47709/stable29
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 3fe5faf5 9763efa7
# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/47709/stable29Error: No changes found in backport branch Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports. |
Member
Author
|
/backport to stable28 |
|
The backport to # Switch to the target branch and update it
git checkout stable28
git pull origin stable28
# Create the new backport branch
git checkout -b backport/47709/stable28
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 3fe5faf5 9763efa7
# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/47709/stable28Error: No changes found in backport branch Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports. |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For the releases, will lower the amount of times we need to compile during releases, this is often more cumbersome than necessary