fix(settings): Fix sharing exclude groups from password requirement option not working#47674
Merged
provokateurin merged 3 commits intomasterfrom Sep 3, 2024
Conversation
provokateurin
requested review from
a team,
nfebe,
skjnldsv and
susnux
and removed request for
a team
provokateurin
force-pushed
the
fix/settings/sharing-enforce-links-password-excluded-groups-key
branch
from
92e8cc0 to
f1c210a
Compare
susnux
approved these changes
Sep 2, 2024
Contributor
susnux
left a comment
susnux
left a comment
There was a problem hiding this comment.
👍
...This settings are pure horror to me, maybe this is something that should be done as declarative settings...
Member
Author
|
True, that would prevent bugs like these. Unfortunately there is still not proper type-safe PHP abstraction available, but it shouldn't be too hard to create. |
Member
Author
|
Created #47688 :) |
artonge
approved these changes
Sep 3, 2024
nfebe
approved these changes
Sep 3, 2024
…ption not working Signed-off-by: provokateurin <kate@provokateurin.de>
Signed-off-by: provokateurin <kate@provokateurin.de>
provokateurin
force-pushed
the
fix/settings/sharing-enforce-links-password-excluded-groups-key
branch
from
f1c210a to
8b79053
Compare
Member
Author
|
/backport to stable30 |
Member
Author
|
/backport to stable29 |
Member
Author
|
/backport to stable28 |
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
provokateurin
deleted the
fix/settings/sharing-enforce-links-password-excluded-groups-key
branch
|
The backport to # Switch to the target branch and update it
git checkout stable28
git pull origin stable28
# Create the new backport branch
git checkout -b backport/47674/stable28
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick c88ae378 8b790535 8aa969b9
# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/47674/stable28Error: Failed to clone repository: Failed to checkout branches: Updating 1cc7851..5118f66
Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports. |
|
The backport to # Switch to the target branch and update it
git checkout stable29
git pull origin stable29
# Create the new backport branch
git checkout -b backport/47674/stable29
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick c88ae378 8b790535 8aa969b9
# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/47674/stable29Error: Failed to clone repository: Failed to checkout branches: Updating 1cc7851..5118f66
Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports. |
|
The backport to # Switch to the target branch and update it
git checkout stable30
git pull origin stable30
# Create the new backport branch
git checkout -b backport/47674/stable30
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick c88ae378 8b790535 8aa969b9
# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/47674/stable30Error: Failed to clone repository: Failed to checkout branches: Updating 1cc7851..5118f66
Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports. |
4 tasks
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
In the backend the appconfig key is
shareapi_enforce_links_password_excluded_groups. The key in the initial state needs to match this as it is used to save the config.To the user it looked like the option wasn't saved because a reload would not show the saved data because it was read from a different key than it was written to.
Checklist