test(cypress): Await promise in response to prevent timeout#47671
Merged
test(cypress): Await promise in response to prevent timeout#47671
Conversation
The idea is to intercept the request, then test the loading state, and after the tests continue the request. Problem here: `cy.intercept` has a timeout on the request-handler which uses the same timeout as DOM assertions (4s) we could increase it, but this also will increase DOM assertion timeout. So instead we do not await in the request handler, but in the response handler. This should use the response timeout which is much higher (30s). Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
artonge
approved these changes
Sep 2, 2024
provokateurin
approved these changes
Sep 2, 2024
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The idea is to:
Problem here:
cy.intercepthas a timeout on the request-handler which uses the same timeout as DOM assertions (4s) we could increase it, but this also will increase DOM assertion timeout.So instead we do not await in the request handler, but in the response handler. This should use the response timeout which is much higher (30s).
Checklist